Provide more context when denying invalid type params #97471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
cjgillot
reviewed
May 28, 2022
There was a problem hiding this comment.
I don't understand the relation between this comment and the match above which defines is_self.
There was a problem hiding this comment.
Expanded the comment
There was a problem hiding this comment.
Isn't T always a slice &[&hir::PathSegment<'_>]? Can't we just take this?
There was a problem hiding this comment.
I tried doing that. It isn't, there are a couple of callers that pass in an Iterator after skipping a few things. I think at least one uses filter_map, which isn't amenable to a direct subslicing approach.
There was a problem hiding this comment.
Nit (pre-existing): an explicit slice may be easier to read.
This comment was marked as resolved.
This comment was marked as resolved.
estebank
force-pushed
the
prohibit-generics
branch
from
9b4436d to
6fdd7e7
Compare
* Confirm the path segment being modified is an `enum` * Check whether type has type param before suggesting changing `Self` * Wording changes * Add clarifying comments * Suggest removing args from `Self` if the type doesn't have type params
estebank
force-pushed
the
prohibit-generics
branch
from
6fdd7e7 to
9d9acff
Compare
This comment was marked as resolved.
This comment was marked as resolved.
estebank
force-pushed
the
prohibit-generics
branch
from
9d9acff to
da126eb
Compare
estebank
force-pushed
the
prohibit-generics
branch
from
da126eb to
ad63f90
Compare
cjgillot
reviewed
Jun 2, 2022
cjgillot
reviewed
Jun 2, 2022
cjgillot
reviewed
Jun 2, 2022
cjgillot
reviewed
Jun 2, 2022
estebank
force-pushed
the
prohibit-generics
branch
from
01fa151 to
31e557b
Compare
estebank
force-pushed
the
prohibit-generics
branch
from
31e557b to
cd8cfbf
Compare
|
@bors r+ |
|
📌 Commit cd8cfbf has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 3, 2022
Provide more context when denying invalid type params
This was referenced Jun 3, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2022
Rollup of 3 pull requests Successful merges: - rust-lang#97415 (Compute `is_late_bound_map` query separately from lifetime resolution) - rust-lang#97471 (Provide more context when denying invalid type params ) - rust-lang#97681 (Add more eslint checks) Failed merges: - rust-lang#97446 (Make hir().get_generics and generics_of consistent.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.